azagrebin opened a new pull request #11675: [Flink 16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args URL: https://github.com/apache/flink/pull/11675 ## What is the purpose of the change `JobManagerProcessUtils#processSpecFromConfig` is used to get `JobManagerProcessSpec` in `AbstractContainerizedClusterClientFactory#getClusterSpecification`. Then `JobManagerProcessSpec` is passed to `ProcessMemoryUtils#generateJvmParametersStr` to get JVM memory arg list string in `YarnClusterDescriptor#setupApplicationMasterContainer` and `JavaCmdJobManagerDecorator#getJobManagerStartCommand`. The configuration is also fixed to fallback to `JobManagerOptions.TOTAL_PROCESS_MEMORY` if a legacy option is set (`JobManagerProcessUtils#getConfigurationWithLegacyHeapSizeMappedToNewConfigOption`) before passing it to `JobManagerProcessUtils#processSpecFromConfig`. Then the JVM memory args are used to start JM container and its JVM process for Yarn and Kubernetes active integrations instead of using the existing legacy heap options: `jobmanager.heap.size` (or `jobmanager.heap.mb`) and container cut-off options: `containerized.heap-cutoff-ratio` and `containerized.heap-cutoff-min`. The container cut-off options are then removed as they have no effect anymore. ## Verifying this change Existing unit tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
