pnowojski commented on issue #11515: [FLINK-16744][task] implement channel state persistence for unaligned checkpoints URL: https://github.com/apache/flink/pull/11515#issuecomment-611176041 👍 Just a word to explain intentions behind those rules. This is a point I was referring to: > There should be no cleanup commits that fix issues that have been introduced in previous commits of the same PR. Commits should be clean in themselves. It's a bit strange that you would be contributing a code and immediately refactor it :) The point that you quoted is about changes to a code that already exists in the master. If you want to: 1. refactor existing method foo in existing class A 2. rename some other variables in class A 3. introduce new feature in class A those should be 3 separate commits in one PR (Arguably 1. and 2. could be squashed, depending on the best judgement). But if you are introducing class A in the same PR, it doesn't make sense to refactor it later.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
