[ 
https://issues.apache.org/jira/browse/FLINK-17067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079280#comment-17079280
 ] 

Zhenghua Gao commented on FLINK-17067:
--------------------------------------

Seems we didn't expose  [OR REPLACE] out yet. 

Most invoking of CatalogManager#createTemporaryTable use "[OR REPLACE] = 
false", which is compatible with "[IF NOT EXISTS] = false".

The only two exceptions are TableEnvironmentImpl#registerTableSourceInternal() 
and TableEnvironmentImpl#registerTableSinkInternal() which are called in 
deprecated APIs (registerTableSource/Sink). 

> CatalogManager#createTable and createTemporaryTable should provide consistent 
> semantics
> ---------------------------------------------------------------------------------------
>
>                 Key: FLINK-17067
>                 URL: https://issues.apache.org/jira/browse/FLINK-17067
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>    Affects Versions: 1.10.0
>            Reporter: Zhenghua Gao
>            Priority: Major
>             Fix For: 1.11.0
>
>
> Currently CatalogManager#createTable provides  [IF NOT EXISTS] semantic and 
> CatalogManager#createTemporaryTable provides [OR REPLACE] semantic. IMO they 
> should provide consistent semantics: [IF NOT EXISTS] or [OR REPLACE].
> I prefer [IF NOT EXISTS] since we didn't support [OR REPLACE] in table 
> DDL(and view DDL) currently.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to