wuchong commented on a change in pull request #11692:
[FLINK-16992][table-common] Add all ability interfaces for table sources and
sinks
URL: https://github.com/apache/flink/pull/11692#discussion_r406674828
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/abilities/SupportsComputedColumnPushDown.java
##########
@@ -64,10 +65,12 @@
* Provides a converter that converts the produced {@link RowData}
containing the physical
* fields of the external system into a new {@link RowData} with
push-downed computed columns.
*
- * <p>Note: Use {@link TableSchema#toRowDataType()} instead of {@link
TableSchema#toPhysicalRowDataType()}
- * for describing the final output data type when creating {@link
TypeInformation}.
+ * <p>Note: Use the passed data type instead of {@link
TableSchema#toPhysicalRowDataType()} for
+ * describing the final output data type when creating {@link
TypeInformation}. If the source implements
+ * {@link SupportsProjectionPushDown}, the projection is already
considered in both the converter
+ * and the given output data type.
*/
- void applyComputedColumn(ComputedColumnConverter converter);
+ void applyComputedColumn(ComputedColumnConverter converter, DataType
outputDataType);
Review comment:
Yes, we need the output data type here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
