[
https://issues.apache.org/jira/browse/FLINK-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060278#comment-15060278
]
ASF GitHub Bot commented on FLINK-3093:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1427#issuecomment-165171199
Hi,
I had a look and have some comments as well
- `ExecutionConfig`: Do we want to make the whole class public? Are we sure
that we do not change the configuration of certain streaming features such as
`enableTimestamps()`, `disableTimestamps()`, `setAutoWatermarkInterval()`? I
find these options in combination with `TimeCharacteristics` very confusing and
I'm not sure if we should mark them already stable. I talked to @aljoscha and
he's not satisfied with the current implementation as well.
- `ExecutionMode`: IMO, the name is quite generic for it's purpose. The
mode is is only relevant for network shuffles in the batch programs.
- `JobExecutionResult.getIntCounterResult()`: Do we need and want to keep
this method? IMO, it should be rather deprecated than marked as stable.
- `Partitioner`: Does it make sense to extend the `partition(K key, int
numPartition)` method by a paramter for the current partitionId? I remember I
had some use cases for this, but forgot about the details.
We need to carefully check the class hierarchy of public/stable classes.
For example, if we make `DefaultInputSplitAssigner` a `Public` interface, we
don't need to make `InputSplitAssigner` `Experimental` because we cannot touch
it then. There might be more of these cases in this PR (and PR #1428).
> Introduce annotations for interface stability
> ---------------------------------------------
>
> Key: FLINK-3093
> URL: https://issues.apache.org/jira/browse/FLINK-3093
> Project: Flink
> Issue Type: New Feature
> Components: Build System
> Affects Versions: 1.0.0
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Priority: Blocker
>
> For the upcoming 1.0 release, we want to mark interfaces as public/stable so
> that we can automatically ensure that newer Flink releases (1.1, 1.2, ..) are
> not breaking them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
