[
https://issues.apache.org/jira/browse/FLINK-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061929#comment-15061929
]
ASF GitHub Bot commented on FLINK-3131:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1453#discussion_r47895579
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateForTask.java
---
@@ -48,18 +48,38 @@
/** The state of the parallel operator */
private final SerializedValue<StateHandle<?>> state;
+ /**
+ * The state size. This is also part of the deserialized state handle.
+ * We store it here in order to not deserialize the state handle when
+ * gathering stats.
+ */
+ private final long stateSize;
+
/** The vertex id of the parallel operator */
private final JobVertexID operatorId;
/** The index of the parallel subtask */
private final int subtask;
+
+ /** The duration of the acknowledged (ack timestamp - trigger
timestamp). */
+ private final long duration;
- public StateForTask(SerializedValue<StateHandle<?>> state, JobVertexID
operatorId, int subtask) {
+ public StateForTask(
+ SerializedValue<StateHandle<?>> state,
+ long stateSize,
+ JobVertexID operatorId,
+ int subtask,
+ long duration) {
+
this.state = checkNotNull(state, "State");
+ // Sanity check and don't fail checkpoint because of this.
+ this.stateSize = stateSize >= 0 ? stateSize : 0;
--- End diff --
Not sure about this. Could `stateSize` also be an Option and be None if it
can't be determined?
> Expose checkpoint metrics
> -------------------------
>
> Key: FLINK-3131
> URL: https://issues.apache.org/jira/browse/FLINK-3131
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Affects Versions: 0.10.1
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
>
> Metrics about checkpoints are only accessible via the job manager logs and
> only show information about the completed checkpoints.
> The checkpointing metrics should be exposed in the web frontend, including:
> - number
> - duration
> - state size
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
