leonardBang commented on a change in pull request #11629: 
[FLINK-14267][connectors/filesystem]Introduce BaseRow Encoder in csv for 
filesystem table sink.
URL: https://github.com/apache/flink/pull/11629#discussion_r407346585
 
 

 ##########
 File path: tools/verify_scala_suffixes.sh
 ##########
 @@ -156,7 +156,9 @@ echo "Checking Scala-dependent modules:"
 
 for module in $infected; do
     out=`find . -maxdepth 3 -name 'pom.xml' -not -path '*target*' -exec grep 
"${module}</artifactId>" "{}" \;`
-    if [[ "$out" == "" ]]; then
+   # skip check flink-csv moudle, flink-csv format depends on dataformat which 
in flink-table-runtime-blink_${scala.binary.version}
 
 Review comment:
   +1 for waiting `BaseRow` move to `table-common` module, I'll update the PR 
after that. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to