[
https://issues.apache.org/jira/browse/FLINK-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062088#comment-15062088
]
ASF GitHub Bot commented on FLINK-3140:
---------------------------------------
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1465#issuecomment-165462700
Thanks for your feedback @tillrohrmann.
Many parts could be expressed in more Scala style, but for performance
reasons and to prevent bugs in this crucial component I chose simple while
loops and tried to be as close as possible to already proven code (esp.
TupleSerializerBase and Fabians NullMaskSerDeUtils). In FLINK-2203 @aljoscha
already mentioned that: "Could you please change this back to the simple while
loop. I know that using the fancy Scala features is tempting but the
performance of a simple while loop should be better than creating a range and
iterating over it using foreach."
> NULL value data layout in Row Serializer/Comparator
> ---------------------------------------------------
>
> Key: FLINK-3140
> URL: https://issues.apache.org/jira/browse/FLINK-3140
> Project: Flink
> Issue Type: Sub-task
> Components: Table API
> Reporter: Chengxiang Li
> Assignee: Timo Walther
>
> To store/materialize NULL value in Row objects, we should need new Row
> Serializer/Comparator which is aware of NULL value fields.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
