kl0u commented on issue #11474: FLINK-10114: Add ORC BulkWriter support for StreamingFileSink URL: https://github.com/apache/flink/pull/11474#issuecomment-612906290 Thanks a lot for following up on this @zenfenan ! The changes that I consider the most important are the moving of the writer to the `flink-orc` module, the changes that decouple the lifecycle of the batch of that of the scope of the `addElement()` and the removal of the requirement to provide the schema twice. The reason I proposed to add the `addUserMetadata ()` is that it seems that it is something that is meant to be exposed to the user (from the javadoc). So if users need it, we have to expose it to them. In addition, it does not seem to be much of a hustle to add it. Is there any particular reason why you would not like to add it?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
