dianfu commented on a change in pull request #11714: [FLINK-17114][python] Set
the default value of 'python.executable' to the path of the python interpreter
which launches the job when the job is executed by LocalExecutor.
URL: https://github.com/apache/flink/pull/11714#discussion_r407821291
##########
File path: flink-python/pyflink/table/tests/test_table_environment_api.py
##########
@@ -440,6 +450,12 @@ def test_table_environment_with_blink_planner(self):
self.assert_equals(results, ['2,hi,hello\n', '3,hello,hello\n'])
+ def test_set_sys_executable_for_local_mode(self):
Review comment:
We should improve the test to eliminate the duplication. It is the same case
for the other test cases in this file and there are many code duplication. You
could refer to test_udf.py on how to eliminate the duplication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
