hequn8128 commented on a change in pull request #11717:
[FLINK-17093][python][table-planner][table-planner-blink] Fix Python UDF to
make it work with inputs from composite field
URL: https://github.com/apache/flink/pull/11717#discussion_r407927071
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/rules/logical/PythonCorrelateSplitRule.java
##########
@@ -93,22 +94,36 @@ public boolean matches(RelOptRuleCall call) {
RexNode rexNode = tableFunctionScan.getCall();
if (rexNode instanceof RexCall) {
return PythonUtil.isPythonCall(rexNode, null) &&
PythonUtil.containsNonPythonCall(rexNode)
- || PythonUtil.isNonPythonCall(rexNode) &&
PythonUtil.containsPythonCall(rexNode, null);
+ || PythonUtil.isNonPythonCall(rexNode) &&
PythonUtil.containsPythonCall(rexNode, null)
+ || (PythonUtil.isPythonCall(rexNode, null) &&
containsFieldAccessInputs(rexNode));
}
return false;
}
+ private boolean containsFieldAccessInputs(RexNode node) {
Review comment:
We don't need this method, use `RexUtil.containsFieldAccess()` directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
