godfreyhe commented on issue #11671: [FLINK-17052] [client] Introduce PlanGenerator URL: https://github.com/apache/flink/pull/11671#issuecomment-613346038 > @godfreyhe I just saw you last commit, I think it was a nice change to pass the `cacheFile` in the constructor of the `PlanGenerator` and register the files there. This delegates the whole process of the "plan creation" to the new class. > > My comment was just to not expose it through the new public method :) oh, I misunderstand you concern. `PlanGenerator` also supports cache registration. but for `TableEnvironment`, the argument of cacheFiles are alway empty, even if `ExecutionEnvironment` has cache files.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
