[ 
https://issues.apache.org/jira/browse/FLINK-17058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083206#comment-17083206
 ] 

Roey Shem Tov commented on FLINK-17058:
---------------------------------------

[~aljoscha] Hope you had great vacation :)

I want relate to your points:
 * yes, the namespace is not changing, but the meaning of this trigger is that 
the user won`t need to set timers at all, like when you using PurgingTrigger 
you don`t need to set purge at all. The purpose of this trigger is to add 
timeout to triggers (e.g count trigger).
 * Fixed
 * Fixed(altaugh it is ProccessingTimeoutTrigger, we can make also to 
eventTrigger or passing flag to constructor)

 

I think the benefit here is to make easy to add any timeout to built-in/custom 
triggers for the "stupid user".

If we take the example of the CountTrigger that is very popular, I bet that 
most users won`t use CountTrigger without any timeout (some keys will never 
getting emit if they dont pass the count threshold).

> Adding TimeoutTrigger support nested triggers
> ---------------------------------------------
>
>                 Key: FLINK-17058
>                 URL: https://issues.apache.org/jira/browse/FLINK-17058
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / DataStream
>            Reporter: Roey Shem Tov
>            Priority: Minor
>         Attachments: ProcessingTimeoutTrigger.java, 
> ProcessingTimeoutTrigger.java
>
>
> Hello,
> first Jira ticket that im opening here so if there is any mistakes of how 
> doing it, please recorrect me.
> My suggestion is to add a TimeoutTrigger that apply as nestedTrigger(as 
> example how the PurgeTrigger does).
> The TimeoutTrigger will support ProcessTime/EventTime and will have 2 timeous:
>  # Const timeout - when the first element of the window is arriving it is 
> opening a timeout of X millis - after that the window will be evaluate.
>  # Continual timeout - each record arriving will increase the timeout of the 
> evaluation of the window.
>  
> I found it very useful in our case when using flink, and i would like to work 
> on it (if it is possible).
> what do you think?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to