wangyang0918 edited a comment on issue #11427: [FLINK-15790][k8s] Make 
FlinkKubeClient and its implementations asynchronous
URL: https://github.com/apache/flink/pull/11427#issuecomment-613795334
 
 
   @azagrebin Thanks for the additional comments. First, i agree with you after 
these changes, `FlinkKubeClient#stopAndCleanupCluster` could also be async.
   
   However, i am just thinking more about this change. After 
[FLINK-17024](https://issues.apache.org/jira/browse/FLINK-17024), we could get 
a safe thread pool to execute the I/O operations. So maybe we could make all 
the `internalDeregisterApplication` implementations executed asynchronously in 
the `#getRpcService#getExecutor()`. And then Flink cluster could shut down a 
little faster. 
   
   Do you have other thoughts or concerns?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to