libenchao commented on a change in pull request #11466:
[FLINK-15400][connectors / elasticsearch] elasticsearch table sink support
dynamic index.
URL: https://github.com/apache/flink/pull/11466#discussion_r408633564
##########
File path:
flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java
##########
@@ -86,6 +97,7 @@ private ElasticsearchSink(
private Map<String, String> bulkRequestsConfig = new
HashMap<>();
private ActionRequestFailureHandler failureHandler = new
NoOpFailureHandler();
private RestClientFactory restClientFactory = restClientBuilder
-> {};
+ private IndexGenerator indexGenerator = new
IndexGenerator(null, null, null);
Review comment:
Does `IndexGenerator` is a must-have field? If yes, maybe we can just check
it is set before `build()`. or we can create a default one before build()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
