[ 
https://issues.apache.org/jira/browse/FLINK-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063920#comment-15063920
 ] 

Stephan Ewen commented on FLINK-2315:
-------------------------------------

I think this is pretty easy to fix.

The {{WritableComparator}} needs to check if the type implements the 
{{NormalizableKey}} interface. 
https://github.com/apache/flink/blob/master/flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/WritableComparator.java

As an example, check out the {{ValueComparator}} which does exactly that: 
https://github.com/apache/flink/blob/master/flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/ValueComparator.java

> Hadoop Writables cannot exploit implementing NormalizableKey
> ------------------------------------------------------------
>
>                 Key: FLINK-2315
>                 URL: https://issues.apache.org/jira/browse/FLINK-2315
>             Project: Flink
>          Issue Type: Bug
>          Components: Java API
>    Affects Versions: 0.9
>            Reporter: Stephan Ewen
>             Fix For: 1.0.0
>
>
> When one implements a type that extends {{hadoop.io.Writable}} and it 
> implements {{NormalizableKey}}, this is still not exploited.
> The Writable comparator fails to recognize that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to