wuchong commented on a change in pull request #11544: [FLINK-16822]
[sql-client] `table.xx` property set from CLI should also be set into
TableEnvironment's TableConfig
URL: https://github.com/apache/flink/pull/11544#discussion_r408696322
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
##########
@@ -771,28 +772,24 @@ public Builder sessionState(SessionState sessionState) {
/** Represents the state that should be reused in one session. **/
public static class SessionState {
- public final TableConfig config;
public final CatalogManager catalogManager;
public final ModuleManager moduleManager;
public final FunctionCatalog functionCatalog;
private SessionState(
- TableConfig config,
CatalogManager catalogManager,
ModuleManager moduleManager,
FunctionCatalog functionCatalog) {
- this.config = config;
this.catalogManager = catalogManager;
this.moduleManager = moduleManager;
this.functionCatalog = functionCatalog;
}
public static SessionState of(
- TableConfig config,
CatalogManager catalogManager,
ModuleManager moduleManager,
FunctionCatalog functionCatalog) {
- return new SessionState(config, catalogManager,
moduleManager, functionCatalog);
+ return new SessionState( catalogManager, moduleManager,
functionCatalog);
Review comment:
```suggestion
return new SessionState(catalogManager, moduleManager,
functionCatalog);
```
remove space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
