azagrebin commented on a change in pull request #11675: [FLINK-16745] Use
JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#discussion_r408748657
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
##########
@@ -18,20 +18,35 @@
package org.apache.flink.client.deployment;
+import org.apache.flink.runtime.jobmanager.JobManagerProcessSpec;
+import org.apache.flink.util.Preconditions;
+
+import static
org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.createDefaultJobManagerProcessSpec;
+
/**
* Description of the cluster to start by the {@link ClusterDescriptor}.
*/
public final class ClusterSpecification {
+ private final JobManagerProcessSpec masterProcessSpec;
Review comment:
ok, I change it know to not extend `ClusterSpecification`. We can continue
discussion in FLINK-16734. In general, I think it would be good to derive
`JobManagerProcessSpec` in one place for all integrations and have plan for
this if it is not in `ClusterSpecification`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
