zenfenan commented on issue #11474: FLINK-10114: Add ORC BulkWriter support for StreamingFileSink URL: https://github.com/apache/flink/pull/11474#issuecomment-614053436 Yes, @kl0u I am moving the codebase to `flink-orc` but before that I think we need to bump ORC dependency version to 1.5.6. Reason why I'm stressing on 1.5.6 is: 1. It is the version I have used in this PR. Haha.. Anyway, if we still want to keep the ORC version as is (i.e. 1.4.3), there will be some code change in the `PhysicalFsWriterImpl`. 2. 1.4.3 which is used in the project is little outdated so it makes sense to use this as an opportunity to upgrade to an even newer and stable version. 3. 1.6.x is not being used anywhere majorly, AFAIK. Even Hive 3.x is using ORC 1.5.6 as the dependency. Having said that, I have created a [Jira](https://issues.apache.org/jira/browse/FLINK-17142) to bump the ORC dependency version to 1.5.6. I did the change locally and tested the flink build with and everything is good so I have just raised a PR #11759. I suggest we merge that first and then this PR. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
