twalthr commented on a change in pull request #11694:
[FLINK-17064][table-planner] Improve literals conversion in ExpressionConverter
URL: https://github.com/apache/flink/pull/11694#discussion_r408864816
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -145,14 +145,53 @@ public void setSqlDialect(SqlDialect sqlDialect) {
}
/**
- * Returns the zone id for timestamp with local time zone.
+ * Returns the current session time zone id. It is used when converting
to/from
+ * {@code TIMESTAMP WITH LOCAL TIME ZONE}. See {@link
#setLocalTimeZone(ZoneId)} for more
+ * details.
+ *
+ * @see org.apache.flink.table.types.logical.LocalZonedTimestampType
*/
public ZoneId getLocalTimeZone() {
return localZoneId;
}
/**
- * Sets the zone id for timestamp with local time zone.
+ * Sets the current session time zone id. It is used when converting
to/from
+ * {@code TIMESTAMP WITH LOCAL TIME ZONE}. Internally timestamps with
local time zone are
+ * normalized to {@code UTC}.
Review comment:
```
Internally, timestamps with local time zone are always represented in the
UTC time zone. However, when converting to data types that don't include a time
zone (e.g. TIMESTAMP, TIME, or simply STRING), the session time zone is used
during conversion.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
