Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1473#discussion_r48154545
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
---
@@ -937,26 +941,40 @@ public ExecutionConfig getExecutionConfig() {
* NO_OVERWRITE and OVERWRITE.
* @param millis
* the file update frequency
- *
+ * @param rowDelimiter
+ * the delimiter for two rows
+ * @param fieldDelimiter
+ * the delimiter for two fields
+ *
* @return the closed DataStream
*/
@SuppressWarnings("unchecked")
- public <X extends Tuple> DataStreamSink<T> writeAsCsv(String path,
WriteMode writeMode,
- long millis) {
- Preconditions.checkArgument(getType().isTupleType(),
- "The writeAsCsv() method can only be used on
data sets of tuples.");
- CsvOutputFormat<X> of = new CsvOutputFormat<X>(new Path(path),
- CsvOutputFormat.DEFAULT_LINE_DELIMITER,
CsvOutputFormat.DEFAULT_FIELD_DELIMITER);
+ public <X extends Tuple> DataStreamSink<T> writeAsCsv(
+ String path,
+ WriteMode writeMode,
+ long millis,
+ String rowDelimiter,
+ String fieldDelimiter) {
+ Preconditions.checkArgument(
+ getType().isTupleType(),
+ "The writeAsCsv() method can only be used on data sets
of tuples.");
--- End diff --
"data sets" should be "data streams"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
