zhijiangW commented on a change in pull request #11351: [FLINK-16404][runtime]
Avoid caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r409259909
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionWithReadViewTest.java
##########
@@ -353,14 +354,32 @@ private void
testBacklogConsistentWithNumberOfConsumableBuffers(boolean isFlushR
}
}
+ @Test
+ public void testBlockedByCheckpointAndResumeConsumption() throws
IOException, InterruptedException {
+
subpartition.add(createFilledFinishedBufferConsumer(BUFFER_SIZE));
+ subpartition.add(createEventBufferConsumer(BUFFER_SIZE,
Buffer.DataType.EXACTLY_ONCE_CHECKPOINT_BARRIER));
+ subpartition.add(createEventBufferConsumer(BUFFER_SIZE,
Buffer.DataType.EVENT_BUFFER));
+
subpartition.add(createFilledFinishedBufferConsumer(BUFFER_SIZE));
+ subpartition.finish();
Review comment:
it is no need to call `finish` for this test, otherwise we also need to
assert `EndofPartitionEvent` below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
