godfreyhe commented on a change in pull request #11671: [FLINK-17052] [client]
Introduce PlanGenerator
URL: https://github.com/apache/flink/pull/11671#discussion_r409272606
##########
File path:
flink-libraries/flink-gelly/src/test/java/org/apache/flink/graph/generator/TestUtils.java
##########
@@ -91,8 +91,6 @@ private TestUtils() {}
* @param expectedParallelism expected operator parallelism
*/
public static void verifyParallelism(ExecutionEnvironment env, int
expectedParallelism) {
- env.setParallelism(2 * expectedParallelism);
Review comment:
One approach is we add a constructor parameter named `defaultParallelism`
for `PlanGenerator`, give the value from `ExecutionEnvironment#getParallelism`.
That does not brake current behavior, but that also means the parallelism from
`ExecutionEnvironment` and from `ExecutionConfig` may be different. WDYT ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
