hequn8128 commented on a change in pull request #11668: [FLINK-17013][python]
Support Python UDTF in old planner under batch mode
URL: https://github.com/apache/flink/pull/11668#discussion_r409297022
##########
File path: flink-python/pyflink/table/tests/test_udtf.py
##########
@@ -81,6 +81,42 @@ class
PyFlinkBlinkStreamUserDefinedFunctionTests(UserDefinedTableFunctionTests,
pass
+class PyFlinkBatchUserDefinedTableFunctionTests(PyFlinkBatchTableTestCase):
+
+ def test_table_function(self):
Review comment:
I'm thinking to avoid these code duplications. Most parts of the code are
the same, we only have to extract the different parts into methods and override
the methods in the child classes. For example, we can add a base method named
`get_output` in the `UserDefinedTableFunctionTests` and override the method in
`PyFlinkBatchUserDefinedTableFunctionTests`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
