Myasuka commented on a change in pull request #11482: [FLINK-16581][table]
Minibatch deduplication lack state TTL bug fix
URL: https://github.com/apache/flink/pull/11482#discussion_r409345494
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/deduplicate/MiniBatchDeduplicateKeepLastRowFunction.java
##########
@@ -59,6 +64,10 @@ public
MiniBatchDeduplicateKeepLastRowFunction(BaseRowTypeInfo rowTypeInfo, bool
public void open(ExecutionContext ctx) throws Exception {
super.open(ctx);
ValueStateDescriptor<BaseRow> stateDesc = new
ValueStateDescriptor<>("preRowState", rowTypeInfo);
+ StateTtlConfig ttlConfig = createTtlConfig(minRetentionTime,
stateCleaningEnabled);
+ if (ttlConfig.isEnabled()) {
Review comment:
No need to check here, just enable a `StateTtlConfig.DISABLED` is okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
