zentol commented on a change in pull request #11778: 
[FLINK-16967][metrics][Slf4j] Refactor Slf4jReporter to be instantiat…
URL: https://github.com/apache/flink/pull/11778#discussion_r409506831
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -587,7 +587,7 @@ function kill_random_taskmanager {
 function setup_flink_slf4j_metric_reporter() {
   INTERVAL="${1:-1 SECONDS}"
   add_optional_lib "metrics-slf4j"
 
 Review comment:
   ```suggestion
     add_optional_plugin "metrics-slf4j"
   ```
   
   This is just a small formality to have the reporter be really loaded as a 
plugin.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to