[
https://issues.apache.org/jira/browse/FLINK-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068586#comment-15068586
]
ASF GitHub Bot commented on FLINK-3140:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1465#discussion_r48288039
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BasicTypeComparator.java
---
@@ -42,6 +42,10 @@ protected BasicTypeComparator(boolean ascending) {
this.ascendingComparison = ascending;
}
+ public boolean isAscendingComparison() {
--- End diff --
There is no need to touch this class, if you overwrite the
`createComparator` method in the `RowTypeInfo` (details below).
> NULL value data layout in Row Serializer/Comparator
> ---------------------------------------------------
>
> Key: FLINK-3140
> URL: https://issues.apache.org/jira/browse/FLINK-3140
> Project: Flink
> Issue Type: Sub-task
> Components: Table API
> Reporter: Chengxiang Li
> Assignee: Timo Walther
>
> To store/materialize NULL value in Row objects, we should need new Row
> Serializer/Comparator which is aware of NULL value fields.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
