[ 
https://issues.apache.org/jira/browse/FLINK-16942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu updated FLINK-16942:
----------------------------
    Summary: ES 5 sink should allow users to select netty transport client  
(was: ES 5 sink should allows users to select netty transport client)

> ES 5 sink should allow users to select netty transport client
> -------------------------------------------------------------
>
>                 Key: FLINK-16942
>                 URL: https://issues.apache.org/jira/browse/FLINK-16942
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / ElasticSearch
>    Affects Versions: 1.9.0, 1.10.0, 1.11.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.9.3, 1.10.1, 1.11.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> When assembling the settings for the {{PreBuiltTransportClient}} the 
> {{Elasticsearch5ApiCallBridge}} first adds the user-provided client and then 
> overrides http/transport types with netty 3.
> This means  that users are forced to use netty 3, despite the connector being 
> able to work with a more recent and secure version.
> {code:java}
> Settings settings = Settings.builder().put(clientConfig)
>       .put(NetworkModule.HTTP_TYPE_KEY, 
> Netty3Plugin.NETTY_HTTP_TRANSPORT_NAME)
>       .put(NetworkModule.TRANSPORT_TYPE_KEY, 
> Netty3Plugin.NETTY_TRANSPORT_NAME)
>       .build();
> {code}
> We should invert the order in which the settings are added.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to