[ 
https://issues.apache.org/jira/browse/FLINK-17177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085601#comment-17085601
 ] 

Yang Wang commented on FLINK-17177:
-----------------------------------

Since i find the fabric8 kubernetes client has a different implementation with 
K8s go client. It will never produce a {{onError}} {{WatchEvent}} on client 
side[1].

But i am not familiar with the K8s ApiServer about when it will return a 
{{Error}} type {{WatchEvent}}. [~felixzheng] Could you share some insight with 
me?

 

[1]. 
[https://github.com/fabric8io/kubernetes-client/blob/1afea0c364a48d9a8745539f84de59630ef6f559/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/WatchHTTPManager.java#L289]

> Handle ERROR event correctly in KubernetesResourceManager#onError
> -----------------------------------------------------------------
>
>                 Key: FLINK-17177
>                 URL: https://issues.apache.org/jira/browse/FLINK-17177
>             Project: Flink
>          Issue Type: Bug
>          Components: Deployment / Kubernetes
>    Affects Versions: 1.10.0, 1.10.1
>            Reporter: Canbin Zheng
>            Priority: Major
>             Fix For: 1.11.0
>
>
> Currently, once we receive an *ERROR* event that is sent from the K8s API 
> server via the K8s {{Watcher}}, then {{KubernetesResourceManager#onError}} 
> will handle it by calling the 
> {{KubernetesResourceManager#removePodIfTerminated}}. This may be incorrect 
> since the *ERROR* event indicates an exception in the HTTP layer that is 
> caused by the K8s Server, which means the previously created {{Watcher}} may 
> be no longer available and we'd better re-create the {{Watcher}} immediately.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to