lirui-apache commented on issue #11788: [FLINK-17209][sql-client] Allow users 
to specify dialect in sql-clien…
URL: https://github.com/apache/flink/pull/11788#issuecomment-615245415
 
 
   I changed the implementations of dialect APIs to use a `ConfigOption`. I 
didn't change the API itself because changing the public API needs more formal 
discussion. This way user can set the dialect with either the API or 
configuration.
   @JingsongLi Do you think it makes sense?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to