tillrohrmann commented on a change in pull request #11109:
[FLINK-15758][MemManager] Release segment and its unsafe memory in GC Cleaner
URL: https://github.com/apache/flink/pull/11109#discussion_r410252210
##########
File path:
flink-core/src/main/java/org/apache/flink/util/JavaGcCleanerWrapper.java
##########
@@ -117,6 +128,22 @@ private static Method getCleanerCleanMethod(Class<?>
cleanerClass) {
}
}
+ private static Method
getSharedSecretsGetJavaLangRefAccessMethod(Class<?> sharedSecretsClass) {
+ try {
+ return
sharedSecretsClass.getMethod("getJavaLangRefAccess");
+ } catch (NoSuchMethodException e) {
+ throw new FlinkRuntimeException("Failed to find
Java legacy SharedSecrets#getJavaLangRefAccess method", e);
+ }
+ }
+
+ private static Method
getJavaLangRefAccessTryHandlePendingReference(Class<?> javaLangRefAccessClass) {
+ try {
+ return
javaLangRefAccessClass.getMethod("tryHandlePendingReference");
+ } catch (NoSuchMethodException e) {
+ throw new FlinkRuntimeException("Failed to find
Java legacy JavaLangRefAccess#tryHandlePendingReference method", e);
+ }
+ }
Review comment:
I think these two methods could be deduplicated via `findMethod(Class<?>
class, String methodName)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
