zhengcanbin commented on issue #11705: [FLINK-16600][k8s] Fix not respecting 
the RestOptions.BIND_PORT for the Kubernetes setup
URL: https://github.com/apache/flink/pull/11705#issuecomment-615706877
 
 
   Hi, @TisonKun @wangyang0918 Thanks for your review and comments. 
   
   The test case of 
`ExternalServiceDecoratorTest#testBuildAccompanyingKubernetesResources` already 
covers the test branch; before this PR, [Line 
72](https://github.com/apache/flink/pull/11705/files#diff-24603b770271a33735073bf3842f07eeR72)
 has checked that the service port equals to the `rest.port`; after this PR, 
[Line 
73](https://github.com/apache/flink/pull/11705/files#diff-24603b770271a33735073bf3842f07eeR73)
 checked that the service target port equals to the `rest.bind-port`, and if we 
don't add this line, 
`ExternalServiceDecoratorTest#testBuildAccompanyingKubernetesResources` will 
definitely fail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to