zhengcanbin commented on a change in pull request #11010: [FLINK-15836][k8s] 
Throw fatal error in KubernetesResourceManager when the pods watcher is closed 
with exception
URL: https://github.com/apache/flink/pull/11010#discussion_r410822987
 
 

 ##########
 File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
 ##########
 @@ -91,6 +93,8 @@
        /** The number of pods requested, but not yet granted. */
        private int numPendingPodRequests = 0;
 
+       private KubernetesWatch podsWatch;
 
 Review comment:
   What are the benefits to wrap all the Kubernetes components we use? 
Currently, I have seen the `KubernetesPod`, `KubernetesResource`, 
`KubernetesService`, and `KubernetesToleration` already. Can we just remove 
such kind of wrappers?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to