Myasuka commented on issue #10768: [FLINK-15012][checkpoint] Introduce shutdown 
to CheckpointStorageCoordinatorView to clean up checkpoint directory.
URL: https://github.com/apache/flink/pull/10768#issuecomment-616186860
 
 
   @StefanRRichter Thanks for your review and suggestions!
   
   The reason why I still want to introduce the option to let checkpoint 
directories could be deleted recursively is observed from actual job-running 
results. We cannot ensure all the files in the checkpoint directory has been 
removed before we just to remove the directory, FLINK-17073 describes a user 
case in which those older checkpoints have not been subsumed in time.
   
   I agree to move the configuration into checkpoint storage scope, and I 
prefer to name that as `state.checkpoints.cleanup.recursive` as checkpoint 
directories are not only used in fs state backend.
   
   I'll update this PR to make the IO operation asynchronously recently, and 
thanks for your review again!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to