[
https://issues.apache.org/jira/browse/FLINK-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076070#comment-15076070
]
ASF GitHub Bot commented on FLINK-3186:
---------------------------------------
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1478#discussion_r48663889
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/util/CollectionDataSets.java
---
@@ -429,7 +418,6 @@ public String toString() {
}
public static class NestedPojo {
- public static Object ignoreMe;
--- End diff --
Fixed, thanks for the feedback
> Deprecate DataSink.sortLocalOutput() methods
> --------------------------------------------
>
> Key: FLINK-3186
> URL: https://issues.apache.org/jira/browse/FLINK-3186
> Project: Flink
> Issue Type: Task
> Components: DataSet API
> Affects Versions: 1.0.0
> Reporter: Fabian Hueske
> Assignee: Suneel Marthi
> Fix For: 1.0.0
>
>
> The DataSet API {{DataSink}} offers a method {{sortLocalOutput()}} to sort
> the output before it is handed to the {{OutputFormat}}.
> I propose to deprecate (and eventually remove) this method, because the same
> functionality can be achieved by using {{DataSet.sortPartition()}}.
> {{sortPartition()}} is more generic and has no drawbacks compared to
> {{sortLocalOutput()}}. Removing {{sortLocalOutput()}} would clean up the API
> and remove unnecessary code paths.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
