twalthr commented on a change in pull request #11397:
URL: https://github.com/apache/flink/pull/11397#discussion_r411152388
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
##########
@@ -196,8 +196,12 @@ public void open() {
if (line == null) {
continue;
}
- final Optional<SqlCommandCall> cmdCall =
parseCommand(line);
- cmdCall.ifPresent(this::callCommand);
+ try {
+ final Optional<SqlCommandCall> cmdCall =
parseCommand(line);
+ cmdCall.ifPresent(this::callCommand);
+ } catch (Throwable t) {
Review comment:
The SQL Client process should not continue if something unexpected
happened. The process might be in a bad state then. We should fail hard in
those cases. The current exception design is also considering this. In the
main() method a wrapping message will be displayed that says `This is a bug.
Please file an issue.`. We should rather fix `CliClient#callSet()` in this case
instead of messing with the exception design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
