tillrohrmann commented on a change in pull request #11353:
URL: https://github.com/apache/flink/pull/11353#discussion_r411421064
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/RegisterApplicationMasterResponseReflectorTest.java
##########
@@ -88,7 +94,44 @@ public void testGetMethodReflectiveHadoop22() {
final RegisterApplicationMasterResponseReflector
registerApplicationMasterResponseReflector =
new RegisterApplicationMasterResponseReflector(LOG);
- final Method method =
registerApplicationMasterResponseReflector.getMethod();
+ final Method method =
registerApplicationMasterResponseReflector.getGetContainersFromPreviousAttemptsMethod();
+ assertThat(method, notNullValue());
+ }
+
+ @Test
+ public void testCallsGetSchedulerResourceTypesMethodIfPresent() {
+ final RegisterApplicationMasterResponseReflector
registerApplicationMasterResponseReflector =
+ new RegisterApplicationMasterResponseReflector(LOG,
HasMethod.class);
+
+ final Optional<Set<String>> schedulerResourceTypeNames =
+
registerApplicationMasterResponseReflector.getSchedulerResourceTypeNamesUnsafe(new
HasMethod());
Review comment:
Makes sense. I agree that your proposal is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
