aljoscha commented on a change in pull request #11334:
URL: https://github.com/apache/flink/pull/11334#discussion_r411493455
##########
File path: flink-table/flink-sql-client/src/main/resources/META-INF/NOTICE
##########
@@ -9,3 +9,4 @@ See bundled license files for details.
- org.jline:jline-terminal:3.9.0
- org.jline:jline-reader:3.9.0
+- com.ibm.icu:icu4j:65.1
Review comment:
The license is ok to add, yes. But in this list it's listed under the
`BSD` licenses. Icu is not licensed under a BSD license. See for example
https://github.com/apache/flink/blob/4035f03a1de24b7e292466e9fa0a0de9cb10f358/flink-dist/src/main/resources/META-INF/NOTICE#L20,
which has many different blocks for different licenses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
