zenfenan edited a comment on issue #11474: URL: https://github.com/apache/flink/pull/11474#issuecomment-616701185
@kl0u I agree with the point that the VectorizedRowBatch shouldn't be exposed to the implementor. I am changing `vectorize()` method to take VectorizedRowBatch as an argument along with `T element`. Regarding the better placement of `addUserMetadata(...)` method. My point was coming from the fact that when a user instantiates `Vectorizer`, the user cannot straightaway call `vectorizer.addUserMetadata(...)` as it will cause an NPE since `Writer` wouldn't have been initialized yet and `setWriter()` wouldn't have been called yet from the `OrcBulkWriter`. Correct? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
