docete opened a new pull request #11837:
URL: https://github.com/apache/flink/pull/11837
…ork for TableEnvironment.connect().createTemporaryTable()
## What is the purpose of the change
Since FLINK-14490, proctime()/rowtime() doesn't work for
TableEnvironment.connect().createTemporaryTable(), The root cause is:
- proctime()/rowtime() are used along with
DefinedRowtimeAttributes/DefinedProctimeAttribute and ConnectorCatalogTable.
The original code path stores the ConnectorCatalogTable object in Catalog and
in validate phrase, the RowType is derived from ConnectorCatalogTable.getSchema
which contains time indicator. After FLINK-14490, we store CatalogTableImpl
object in Catalog and in validate phrase, the RowType is derived from
CatalogTableImpl.getSchema which doesn't contain time indicator.
- In SqlToRel phrase, FlinkCalciteCatalogReader converts
ConnectorCatalogTable to TableSourceTable and converts CatalogTable to
CatalogSourceTable. The TableSourceTable would be converted to LogicalTableScan
directly and contains time indicator. Otherwise the CatalogSourceTable would be
converted to a LogicalTableScan whose time indicator is erased(by FLINK-16345).
This PR fix it.
## Brief change log
- instantiate the TableSource in CatalogSchemaTable and check if it's a
DefinedRowtimeAttributes/DefinedProctimeAttribute instance. If so, rewrite the
TableSchema to patch the time indicator(as it is in
ConnectorCatalogTable#calculateSourceSchema)
- Avoid erasing time indicator in CatalogSourceTable if the TableSource is a
DefinedRowtimeAttributes/DefinedProctimeAttribute instance
## Verifying this change
This change added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs /
**JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
