docete commented on a change in pull request #11727:
URL: https://github.com/apache/flink/pull/11727#discussion_r411902392
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala
##########
@@ -946,6 +946,485 @@ class CatalogTableITCase(isStreamingMode: Boolean)
extends AbstractTestBase {
expectedProperty.put("k2", "b")
assertEquals(expectedProperty, database.getProperties)
}
+
Review comment:
Add the IT cases to verify the views actually works (query a view
returns expected records).
I can move this to a new CatalogViewITCase, So we have CatalogTableITCase
for table DDL, FunctionITCase for function DDL and CatalogViewITCase for view
DDL. what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
