aljoscha commented on a change in pull request #11473:
URL: https://github.com/apache/flink/pull/11473#discussion_r412170561
##########
File path:
flink-core/src/main/java/org/apache/flink/core/execution/PipelineExecutor.java
##########
@@ -41,5 +41,5 @@
* @param configuration the {@link Configuration} with the required
execution parameters
* @return a {@link CompletableFuture} with the {@link JobClient}
corresponding to the pipeline.
*/
- CompletableFuture<JobClient> execute(final Pipeline pipeline, final
Configuration configuration) throws Exception;
+ CompletableFuture<? extends JobClient> execute(final Pipeline pipeline,
final Configuration configuration) throws Exception;
Review comment:
Yes, it's not a problem for the API. It just makes the internal
signatures more wordy and I was surprised because I had to rebase some of my
changes. 😅
I think the problem here is that Java in some situations can't type-check
the code, if the `whenComplete()` would be removed it's happy to accept the
result as a `CompletableFuture<JobClient>`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
