GJL commented on a change in pull request #11615:
URL: https://github.com/apache/flink/pull/11615#discussion_r412316648
##########
File path: docs/_includes/generated/expert_scheduling_section.html
##########
@@ -14,6 +14,12 @@
<td>Boolean</td>
<td>Enable the slot spread out allocation strategy. This strategy
tries to spread out the slots evenly across all available <span
markdown="span">`TaskExecutors`</span>.</td>
</tr>
+ <tr>
+ <td><h5>slotmanager.number-of-slots.max</h5></td>
Review comment:
Unresolved to keep the discussion visible.
Within the people I asked, there is no clear consensus which style is
better. As Xintong already said, it can make sense to treat
`number-of-slots.[min|max]` as a pair. However, I prefer `max-xyz` because
- There are properties where `min` does not make sense
- It is easier for a user to remember that there is only one style
That being said, to decide on a project-wide naming convention, it should be
discussed on the dev ML. Maybe you want to start a thread, @KarmaGYZ? In the
mean time I would be okay with both styles but I can see that you have already
changed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
