KarmaGYZ commented on a change in pull request #11615:
URL: https://github.com/apache/flink/pull/11615#discussion_r412613935



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -386,6 +392,12 @@ public void registerTaskManager(final 
TaskExecutorConnection taskExecutorConnect
                if 
(taskManagerRegistrations.containsKey(taskExecutorConnection.getInstanceID())) {
                        
reportSlotStatus(taskExecutorConnection.getInstanceID(), initialSlotReport);
                } else {
+                       if 
(totalSlotNumExceedMaxLimitAfterRegister(initialSlotReport)) {
+                               LOG.warn("The total number of slots exceeds the 
max limitation {}, release the excess resource.", maxSlotNum);

Review comment:
       Conceptually, this should be the expected behavior. Maybe it makes sense 
to change the level to `INFO`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to