Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1397#issuecomment-169861378
Hi @rawkintrevo, I'm sorry about waiting you.
I have looked your pull request. Almost of changes are good but I have some
few comments.
First, there are some meaningless changes such as indentation in
`flink-ml/pom.xml` file and definition of `optimize` method of
`GradientDescent` class. Please revert this changes.
Second, how about using `Enum` for the added parameter? Numbers cannot
express meaning of optimization method.
Third, I think that we should apply this changes to documentation. Please
add this content into the FlinkML documentation. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
