godfreyhe commented on a change in pull request #11797:
URL: https://github.com/apache/flink/pull/11797#discussion_r413764767
##########
File path:
flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/util/GenericRowRecordSortComparator.java
##########
@@ -43,10 +44,10 @@ public GenericRowRecordSortComparator(int sortKeyIdx,
LogicalType sortKeyType) {
@Override
public int compare(GenericRow row1, GenericRow row2) {
- byte header1 = row1.getHeader();
- byte header2 = row2.getHeader();
- if (header1 != header2) {
- return header1 - header2;
+ RowKind kind1 = row1.getRowKind();
+ RowKind kind2 = row2.getRowKind();
+ if (kind1 != kind2) {
+ return kind1.ordinal() - kind2.ordinal();
Review comment:
use byte value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
