tillrohrmann commented on a change in pull request #10228:
URL: https://github.com/apache/flink/pull/10228#discussion_r413796896
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/FileType.java
##########
@@ -22,6 +22,18 @@
* Different file types to request from the {@link TaskExecutor}.
*/
public enum FileType {
+ /**
+ * the log file type for taskmanager
+ */
LOG,
- STDOUT
+
+ /**
+ * the stdout file type for taskmanager
+ */
+ STDOUT,
+
+ /**
+ * the thread dump type for taskmanager
+ */
+ THREAD_DUMP
Review comment:
I disagree since we are not requesting a file here. We are only using
the file transfer mechanism to send the data.
The file transfer aspect is another thing we should discuss. Wouldn't it be
possible and simpler to directly send the stringified stack trace instead of
using the blob service?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
