twalthr commented on a change in pull request #11797:
URL: https://github.com/apache/flink/pull/11797#discussion_r413934051
##########
File path: flink-core/src/main/java/org/apache/flink/types/RowKind.java
##########
@@ -47,10 +47,69 @@
* needs to retract the previous row first. OR it describes an
idempotent update, i.e., an update
* of a row that is uniquely identifiable by a key.
*/
- UPDATE_AFTER,
+ UPDATE_AFTER("UA", (byte) 2),
/**
* Deletion operation.
*/
- DELETE
+ DELETE("D", (byte) 3);
+
+ private final String shortString;
+
+ private final byte value;
+
+ /**
+ * Creates a {@link RowKind} enum with the given short string and byte
value representation of
+ * the {@link RowKind}.
+ */
+ RowKind(String shortString, byte value) {
+ this.shortString = shortString;
+ this.value = value;
+ }
+
+ /**
+ * Returns a short string representation of this {@link RowKind}.
+ *
+ * <p><ul>
Review comment:
But users that only look at JavaDocs are usually not the ones that
should work with byte values for performance reasons :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
