azagrebin commented on a change in pull request #11615:
URL: https://github.com/apache/flink/pull/11615#discussion_r414556677



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/StandaloneResourceManagerFactory.java
##########
@@ -74,4 +81,20 @@
                        standaloneClusterStartupPeriodTime,
                        AkkaUtils.getTimeoutAsTime(configuration));
        }
+
+       /**
+        * Get the configuration for standalone ResourceManager, overwrite 
invalid configs.
+        *
+        * @param configuration configuration object
+        * @return the configuration for standalone ResourceManager
+        */
+       private static Configuration 
getConfigurationForStandaloneResourceManager(Configuration configuration) {

Review comment:
       ```suggestion
        private static Configuration 
getConfigurationWithoutMaxSlotNumberIfSet(Configuration configuration) {
   ```
   As this is the only thing which is done here now, I would suggest to be more 
explicit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to