patricklucas commented on pull request #9: URL: https://github.com/apache/flink-docker/pull/9#issuecomment-619050617
Sorry for not getting to this sooner. The results look good. I continue to rue the complexity of the bash scripts, especially the stackbrew library one—maybe I'll follow through on my threat of rewriting it in Python at some point. I verified that the resulting library manifest only adds new tags, and that the Java 8 image is preferred. I of course would also be happy to have only Java 11 images—or at least, making the Java 11 images be the default-tagged starting with Flink 1.11—but I'm not sure the community is ready for that yet. A discussion/call for reviews on the mailing list seems appropriate, but I'm not sure if this is the sort of thing that requires a vote, since it is only a packaging change, and not a Flink "upstream" source change. Regarding the build helper Docker image, I replied on the FLINK ticket about it. I think actually the best option would be to have some tooling that runs a vanilla Alpine or Debian container, downloads the bashbrew library from [here](https://doi-janky.infosiftr.net/job/bashbrew/lastSuccessfulBuild/artifact/bin/) (as suggested by the bashbrew README), and then runs the script, avoiding a requirement on any prebuilt image. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
